fix: protect Cat indexing from missing values #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #387. This will likely have a performance impact on accessing histograms, should be checked. |
andrzejnovak
force-pushed
the
indexfix
branch
5 times, most recently
from
53b4695 to
7953d2a
Compare
|
@henryiii fixed the tests |
chore: make pre-commit happy fix: handle errors in C++ style: pre-commit fixes fix: ensure consistent passing fix: C++17 makes noexcept part of the type system style: pre-commit fixes fix: too much noexcept
|
We are throwing a KeyError for a missing Category, and not throwing for Integer or other axes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category indexing will return
len(index)+1for missing index, which creates messy error messages down the line.This should catch it correctly
Closes #387.