Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support pick_set inside a larger expression #793

Merged
merged 2 commits into from
Sep 19, 2022
Merged

fix: support pick_set inside a larger expression #793

merged 2 commits into from
Sep 19, 2022

Conversation

henryiii
Copy link
Member

@henryiii henryiii commented Sep 17, 2022 •
edited
Loading

Fix #715.

@henryiii
tests: adding pick inside a larger expression
53b99ab 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@github-actions github-actions bot added the needs changelog Might need a changelog entry label Sep 17, 2022
@henryiii
fix: allow picking and pick_set to coexist
0050906 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii marked this pull request as ready for review September 19, 2022 16:23
@henryiii henryiii changed the title tests: adding pick inside a larger expression fix: support pick_set inside a larger expression Sep 19, 2022
@henryiii henryiii merged commit 4ebce75 into develop Sep 19, 2022
@henryiii henryiii deleted the henryiii/fix/picksecond branch September 19, 2022 16:28
@henryiii henryiii removed the needs changelog Might need a changelog entry label Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Indexing along two axes with list and single index raises RuntimeError
1 participant
@henryiii