feat: Add -latomic link arg for armv7l machines #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Required if building on 32-bit Raspberry Pi. c.f. piwheels/packages#341 Note from the setuptools v65.6.3 docs https://setuptools.pypa.io/en/stable/userguide/ext_modules.html#compiler-and-linker-options > The linker options appear in the command line in the following order: > > * first, the options provided by environment variables and sysconfig variables, > * then, a -L option for each element of Extension.library_dirs, > * then, a linker-specific option like -Wl,-rpath for each element of Extension.runtime_library_dirs, > * finally, the options provided by Extension.extra_link_args. Here extra_link_args is used as this seems the most straightforward.
henryiii
force-pushed
the
feat/add-support-for-armv7l
branch
from
e2e78cf to
93d1b7d
Compare
|
Gentle ping to @henryiii on this, as this had fallen off of my radar and so I assume yours as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #822
Required if building on 32-bit Raspberry Pi. c.f. piwheels/packages#341
Note from the setuptools v65.6.3 docs
Here
extra_link_argsis used as this seems the most straightforward.