Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disallow nbsphinx v0.8.8 to avoid empty "raw" directive bug #1742

Merged
merged 4 commits into from
Jan 4, 2022

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Jan 4, 2022

Description

Disallow nbsphinx v0.8.8 as it introduces a bug for empty 'raw' directives (c.f. spatialaudio/nbsphinx#620). This is fixed in spatialaudio/nbsphinx#621 and so should work its way into the next nbsphinx release. 👍

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Disallow nbsphinx v0.8.8 as it introduces a bug for empty 'raw' directives.
   - c.f. https://github.com/spatialaudio/nbsphinx/issues/620

@matthewfeickert matthewfeickert added fix A bug fix build Changes that affect the build system or external dependencies labels Jan 4, 2022
@matthewfeickert matthewfeickert self-assigned this Jan 4, 2022
@matthewfeickert matthewfeickert added the docs Documentation related label Jan 4, 2022
@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #1742 (4d99705) into master (af6c09a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1742   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files          64       64           
  Lines        4270     4270           
  Branches      683      683           
=======================================
  Hits         4190     4190           
  Misses         46       46           
  Partials       34       34           
Flag Coverage Δ
contrib 26.25% <ø> (ø)
doctest 60.58% <ø> (ø)
unittests 96.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af6c09a...4d99705. Read the comment docs.

@matthewfeickert matthewfeickert merged commit c295587 into master Jan 4, 2022
@matthewfeickert matthewfeickert deleted the fix/update-nbsphinx branch January 4, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencies docs Documentation related fix A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant