-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: local http server for tests #1010
Conversation
This particular package isn't super well-maintained (it has a single maintainer who's expressed an interest in handing off to someone else). However, it's also a very simple, self-contained part of the test system, and there is interest from another developer in maintaining. We could probably just vendor it in future, if we need to. So, on the balance of cost-tradeoffs, I think this is a sensible inclusion. It gets my approval — but definitely wait for Jim's review, too. |
Add a local http server pytest fixture. The http server is the python built-in but the request handler comes from https://github.com/danvk/RangeHTTPServer since the python one does not handle range requests. This handler also supports multipart range header requests!
The current implementation serves files from the
skhep_testdata
cache directory and downloads them on demand (only once) via calls toskhep_testdata.data_path
.There is an open issue to add this to python: python/cpython#86809.
I replaced most of the previous instances of remote http access by this local server but not all of them.
This PR also enables back some tests that were marked as skip due to network issues.