Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix ReadTheDocs documentation #1084

Merged
merged 11 commits into from
Jan 16, 2024

Conversation

jpivarski
Copy link
Member

No description provided.

@jpivarski jpivarski linked an issue Jan 16, 2024 that may be closed by this pull request
@jpivarski
Copy link
Member Author

I got an email and there's the docs/readthedocs.org:uproot test failure above.

I made it a required test, so I probably don't need the emails. PRs will need to keep the docs working.

@jpivarski
Copy link
Member Author

Next issue:

At least one item should be provided in "tools" or "commands".

@jpivarski
Copy link
Member Author

Despite all of these build failures, I only got an email notification from the first one in this PR. That's also not particularly useful... I'm turning off the email notifications now.

@jpivarski
Copy link
Member Author

That worked, and we see the difference between this build and the latest (which will change after I merge this PR).

A snapshot of differences in uproot.open:

Latest:

image

...

image

This PR:

image

...

image

Nobody complained that the docs were out of date...

@jpivarski jpivarski enabled auto-merge (squash) January 16, 2024 18:28
@jpivarski jpivarski merged commit 10f1267 into main Jan 16, 2024
21 checks passed
@jpivarski jpivarski deleted the jpivarski/fix-readthedocs-documentation branch January 16, 2024 18:34
lobis added a commit that referenced this pull request Jan 22, 2024
* origin/main: (41 commits)
  chore: hatch-vcs generates 'version.py'; add it to .gitignore
  docs: add bnavigator as a contributor for test (#1087)
  feat: support for writing hist derived profiles (#1000)
  feat: add the ability to read RNTuple alias columns (#1004)
  chore: update pre-commit hooks (#1082)
  docs: fix ReadTheDocs documentation (#1084)
  chore: update pre-commit hooks (#1073)
  chore(deps): bump actions/upload-artifact from 3 to 4 (#1071)
  chore(deps): bump actions/download-artifact from 3 to 4 (#1072)
  build: change build to autogen version info (#1062)
  chore: remove src/uproot/version.py (for #1062).
  The next release will be 5.2.1.
  add known_base_form option so that opening root files can be avoided for mature analyses (#1077)
  test: fsspec cache (#1075)
  test: xrootd server fixture (#1076)
  The next release will be 5.2.0.
  fix: correct typo in fsspec globbing (#1067)
  chore(deps): bump actions/setup-python from 4 to 5 (#1059)
  The next release will be 5.2.0rc5.
  fix: dask distributed fsspec issue (#1065)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the ReadTheDocs build
1 participant