fix: allow writing generic UHI-compatible histograms #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UHI-compatible histograms should have a function variances, but are not required to have a storage_type. Also, if the histogram is not from hist or boost_histogram, boost_histogram is None and the storage type check fails.
jpivarski
changed the title
jpivarski
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Thanks! We do want to ensure that arbitrary UHI histograms are writable, but this slipped in because we don't have any non-boost histogram types to test. (In principle, we could mock up a new histogram type that satisfies UHI, although that would be quite a bit more work.)
If you're done with this PR and it passes all tests, I'll merge it.
|
Let me know if you're done and I'll merge it! |
|
I think this is done. I'm merging it now. Thanks! |
|
@all-contributors please add @YSelfTool for code |
|
I've put up a pull request to add @YSelfTool! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit ec80b88 broke support for writing histograms that fulfill the Unified Histogram Interface, but are neither from hist nor from boost_histogram. UHI compatible histograms always have a function
variances, but do not have astorage_typeattribute, so that attribute should only be checked if the histogram is indeed from boost_histogram.