-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: miscellaneous RNTuple improvements #1250
Draft
ariostas
wants to merge
11
commits into
main
Choose a base branch
from
ariostas/misc_rntuple_improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariostas
commented
Sep 5, 2024
Comment on lines
+211
to
+236
rntuple_locator_type_uri = 0x01 | ||
rntuple_locator_type_daos = 0x02 | ||
|
||
rntuple_env_type_header = 0x01 | ||
rntuple_env_type_footer = 0x02 | ||
rntuple_env_type_pagelist = 0x03 | ||
rntuple_env_type_metadata = 0x04 | ||
|
||
rntuple_field_role_leaf = 0x00 | ||
rntuple_field_role_vector = 0x01 | ||
rntuple_field_role_struct = 0x02 | ||
rntuple_field_role_union = 0x03 | ||
rntuple_field_role_unsplit = 0x04 | ||
|
||
rntuple_field_flag_repetitive = 0x01 | ||
rntuple_field_flag_projected = 0x02 | ||
rntuple_field_flag_checksum = 0x04 | ||
|
||
rntuple_col_flag_deferred = 0x08 | ||
|
||
rntuple_extra_type_identifier_root = 0x00 | ||
|
||
rntuple_user_metadata_type_int = 0x01 | ||
rntuple_user_metadata_type_bool = 0x02 | ||
rntuple_user_metadata_type_double = 0x03 | ||
rntuple_user_metadata_type_string = 0x04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe these should be enums
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issues in #1220. I fixed the
__len__
method so that it returns the number of top-level columns instead of the number of entries, which is now thenum_entries
property.I'll work on implementing an
iterate
method and update this description when it's ready.