Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran repo-review (below) and fixed most of the issues. The
warn_unreachable
one I think should probably check for existence, not the True setting.See scientific-python/cookie#348 for the grouping update.
Repo-review:
General
hatchling.build
PyProject
GitHub Actions
Projects should group their updates to avoid extra PRs and stay in sync. This is now supported by dependabot since June 2023.
Pre-commit
MyPy
Must not have
show_error_codes
. Usehide_error_codes
instead (since MyPy v0.990).Ruff
extend-ignore
deprecated, useignore
instead (identical)extend-ignore
should be set aslint.extend-ignore
insteadisort
should be set aslint.isort
insteadper-file-ignores
should be set aslint.per-file-ignores
insteadselect
should be set aslint.select
insteadtyping-modules
should be set aslint.typing-modules
insteadunfixable
should be set aslint.unfixable
insteadDocumentation
Validate-PyProject
Checks
[build-system]
,[project]
,[tool.repo-review]
,[tool.setuptools]