Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ruff config #7387

Merged
merged 5 commits into from
Apr 11, 2024
Merged

Conversation

jarrodmillman
Copy link
Contributor

@jarrodmillman jarrodmillman commented Apr 11, 2024

Description

  1. Update pyproject.toml to use ruff's new linter settings (the old way has been deprecated).
  2. Use project.requires-python instead of tool.ruff.target-version as recommended by ruff.
  3. Use NPY201 linter rule (hopefully this would have caught things like Use numpy.inf instead of deprecated numpy.infty #7386.
  4. Remove line-length and exclude.

Checklist

Release note

We use changelist to
compile each pull request into an item of the release notes. Please refer to
the instructions
and past release notes
for guidance and examples.

...

The top-level linter settings are deprecated in favour of their counterparts in the `lint` section.
This is the recommended way to do this.
@jarrodmillman jarrodmillman added the 🔧 type: Maintenance Refactoring and maintenance of internals label Apr 11, 2024
@jarrodmillman jarrodmillman requested a review from lagru April 11, 2024 14:02
Copy link
Member

@lagru lagru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with all the changes here except for the one noted.

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Copy link
Member

@lagru lagru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the condition that the CI is happy. :)

@jarrodmillman jarrodmillman added this to the 0.23.2 milestone Apr 11, 2024
@jarrodmillman jarrodmillman merged commit d75f515 into scikit-image:main Apr 11, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants