Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncomment currentmodule directive again #7492

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

lagru
Copy link
Member

@lagru lagru commented Aug 11, 2024

Description

This line was left commented as an oversight from debugging #7485 and #7486.

It didn't seem to cause any problems but let's put it back in to be safe. I'm a bit fuzzy on this because I can't find a good answer in Sphinx docs to how those two directives interact and why it seems to work with and without.

Checklist

Release note

For maintainers and optionally contributors, please refer to the instructions on how to document this PR for the release notes.

...

This line was left commented as an oversight from debugging
https://www.github.com/scikit-image/scikit-image/issues/7485 and
https://www.github.com/scikit-image/scikit-image/pull/7486.

It didn't seem to cause any problems but let's put it back in to be
safe. I'm a bit fuzzy on this because I can't find a good answer in
Sphinx docs to how those two directives interact and why it seems to
work with and without.
@lagru lagru added 🤖 type: Infrastructure CI, packaging, tools and automation 🚀 Quick win Trivial, small, easy to address or review labels Aug 11, 2024
@stefanv stefanv merged commit dfef2bd into scikit-image:main Aug 13, 2024
27 checks passed
@stefanv stefanv added this to the 0.25 milestone Aug 13, 2024
@lagru lagru deleted the uncomment-currentmodule branch August 13, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 type: Infrastructure CI, packaging, tools and automation 🚀 Quick win Trivial, small, easy to address or review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants