-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scikit-learn 1.3.0 release induce a bug #597
Comments
Yes, it looks like they've refactored how all of that works quite a bit. There's no easy way to handle that anymore looking at the current setup. I think the best options would be to hardcode a list of acceptable metrics from what KDTrees and BallTrees in sklearn currently accept. Eventually the dual-tree Boruvka code from here will be merged into sklearn proper, at which point this will be less of an issue. If you wanted to compile the metrics and put in a PR to fix this that would be appreciated. Otherwise it may have to wait until I get to it. |
This works around breakage in hdbscan scikit-learn-contrib/hdbscan#597 caused by API changes in scikit-learn 1.3.0
This works around breakage in hdbscan scikit-learn-contrib/hdbscan#597 caused by API changes in scikit-learn 1.3.0
This works around breakage in hdbscan scikit-learn-contrib/hdbscan#597 caused by API changes in scikit-learn 1.3.0
This works around breakage in hdbscan scikit-learn-contrib/hdbscan#597 caused by API changes in scikit-learn 1.3.0
This should be fixed in master now. I'll see if I can get a release out soon. |
Sorry, didn’t have time to work on that but thanks for the fix :) |
FAST_METRICS = KDTree.valid_metrics + BallTree.valid_metrics + ["cosine", "arccos"]
l.40 in https://github.com/scikit-learn-contrib/hdbscan/blob/master/hdbscan/hdbscan_.py
doesn't work anymore with sklearn last release 1.3.0
The text was updated successfully, but these errors were encountered: