Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update paper ref after JMLR acceptance #301

Merged
merged 2 commits into from
Jul 30, 2020

Conversation

bellet
Copy link
Member

@bellet bellet commented Jul 28, 2020

This updates the reference to the metric-learn paper in the README and the doc, following acceptance to JMLR

@bellet
Copy link
Member Author

bellet commented Jul 28, 2020

@wdevazelhes could you please update the doc branch after merging this so that the change is immediately reflected in the doc website? Thanks!

@bellet
Copy link
Member Author

bellet commented Jul 28, 2020

The failing test is unrelated to this PR - but it was documented in #264. We should fix this separately

@wdevazelhes
Copy link
Member

@wdevazelhes could you please update the doc branch after merging this so that the change is immediately reflected in the doc website? Thanks!

Sure, will do!

@wdevazelhes wdevazelhes merged commit 730abf1 into scikit-learn-contrib:master Jul 30, 2020
@bellet bellet deleted the jmlr_ref branch July 30, 2020 13:35
@bellet
Copy link
Member Author

bellet commented Jul 30, 2020

Thanks!

@wdevazelhes
Copy link
Member

done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants