Fix 4 tests #321
Merged
Fix 4 tests #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -929,7 +929,7 @@ def test_singleton_class(self): | |||
| X = X[[ind_0[0], ind_1[0], ind_2[0]]] | |||
| y = y[[ind_0[0], ind_1[0], ind_2[0]]] | |||
|
|
|||
| A = make_spd_matrix(X.shape[1], X.shape[1]) | |||
| A = make_spd_matrix(n_dim=X.shape[1], random_state=X.shape[1]) | |||
There was a problem hiding this comment.
Where are you observing the failed tests? I see the CI has been passing.
There was a problem hiding this comment.
From branch master with a fresh virtual environment I got these errors:
FAILED test/metric_learn_test.py::TestSCML::test_iris[lda] - assert 0.255932896034129 < 0.24
FAILED test/metric_learn_test.py::TestNCA::test_one_class - TypeError: make_spd_matrix() takes 1 positional argument but 2 were given
FAILED test/metric_learn_test.py::TestNCA::test_singleton_class - TypeError: make_spd_matrix() takes 1 positional argument but 2 were given
FAILED test/test_mahalanobis_mixin.py::test_init_mahalanobis[MMC] - TypeError: make_spd_matrix() takes 1 positional argument but 2 were given
FAILED test/test_mahalanobis_mixin.py::test_init_mahalanobis[MMC_Supervised] - TypeError: make_spd_matrix() takes 1 positional argument but 2 were given
4 of them are due to make_spd_matrix() function
terrytangyuan
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5 Tests were not passing because of make_spd_matrix() function. The usage was incorrect.
According to documentation, you just need to provide n_dim and random_state, in order to generate the random spd matrix.
With this little change, those tests pass