Change min sklearn version to 0.21.3 #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewing the release notes of sklearn (here), I realized that the version that is being checked in CI is 0.20.3 wich has an official support for Python 2.7 and 3.4 only.
This is inconsistent, because metric_learn only supports Python 3.6+.
Then, the minimum version of sklearn allowed should be 0.21.3 wich is the older version officially supporting Python 3.6. Also the older version with documentation (here).
There should also be restrictions to numpy and scipy, to at least match the minimum versions required for sklearn 0.21.3.
For the CI, only Python 3.6 and 3.7 should be checked, as only these verions are officially supported by sklearn 0.21.3
Modified: setup.py, readme, docs and CI