Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLEP015: Feature Names Propagation #48

Merged
merged 14 commits into from
Nov 30, 2022
Merged

SLEP015: Feature Names Propagation #48

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
3b6631d
DOC Adds slep015
thomasjpfan Oct 3, 2020
55b62f6
DOC Adjust wording to allow Pipeline to store
thomasjpfan Oct 5, 2020
2f1d2f8
DOC Adds more details
thomasjpfan Oct 6, 2020
22b9b00
DOC Adds more details about array_out
thomasjpfan Oct 6, 2020
4392546
CLN Address comments
thomasjpfan Oct 6, 2020
0608c37
DOC Address comments
thomasjpfan Oct 10, 2020
902f792
DOC Adds details
thomasjpfan Oct 10, 2020
1fff514
DOC Adjust styling
thomasjpfan Oct 10, 2020
388eda8
DOC Adds more details
thomasjpfan Oct 14, 2020
7537b15
DOC Comment about meta-estimators
thomasjpfan Oct 14, 2020
8916cb1
DOC Comment about get_feature_names
thomasjpfan Oct 14, 2020
e9b275c
CLN Address comments
thomasjpfan Oct 14, 2020
ffd0954
DOC Specify data type
thomasjpfan Oct 14, 2020
3f6426f
Merge remote-tracking branch 'upstream/master' into slep015_feature_n…
thomasjpfan Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion slep015/proposal.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,10 @@ Considerations and Limitations
a pipeline with no steps. We can work around this by allowing pipelines
with no steps.

3. Meta-estimators will delegate the setting and validation of
3. ``feature_names_in_`` can be any 1-D ``Sequence``, such as an list or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But ndarray is not a sequence: numpy/numpy#2776

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "Iterable that returns a string" would be enough.

In our discussions, I think we want to make sure the feature names are strings.

Copy link
Member

@jnothman jnothman Oct 14, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. We'd better accept Sequences and 1d array-likes whose elements are strings: pd.Index is not a Sequence.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. ``feature_names_in_`` can be any 1-D ``Sequence``, such as an list or
3. ``feature_names_in_`` can be any 1d array-like of strings, such as an list or

an ndarray.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth noting that this allowance can avoid unnecessary memory consumption/copies, with reduced implementation complexity, although it may reduce usability a bit.


4. Meta-estimators will delegate the setting and validation of
``feature_names_in_`` to its inner estimators. The meta-estimator will
define ``feature_names_in_`` by referencing its inner estimators. For
example, the ``Pipeline`` can use ``steps[0].feature_names_in_`` as
Expand Down