RFC/WIP Feature names within fit #14238
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #12627 that I proposed in scikit-learn/enhancement_proposals#18
Basically I think now it's better to have the feature names as close to X as possible, so they are not out of sync, and I want the user interface to be as small as possible.
This PR adds
feature_names_in
as a parameter tofit
, and addsfeature_names_in_
as an attribute to every estimator, andfeature_names_out_
as an attribute to all transformers.Other alternatives that do basically the same but don't require an attribute to fit are:
feature_names_in
attribute manually