Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: use notebook-style for plot_svm_regression.py example #22534

Merged
merged 4 commits into from
Feb 19, 2022

Conversation

jayasuryajsk
Copy link
Contributor

@jayasuryajsk jayasuryajsk commented Feb 18, 2022

Fixed the html rendering issue on the website for this example as per the instructions given.

Part of #22406

Copy link
Member

@lesteve lesteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the comments into titles by using --- (of the right length)? I made a suggestion for the first one if you can handle the others in a similar way this would be great!

@@ -11,22 +11,22 @@
from sklearn.svm import SVR
import matplotlib.pyplot as plt

# #############################################################################
# %%
# Generate sample data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Generate sample data
# Generate sample data
# --------------------

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. Done.

@lesteve
Copy link
Member

lesteve commented Feb 19, 2022

I reopened this PR and pushed some tweaks.

Pieces of advice:

@jayasuryajsk
Copy link
Contributor Author

I reopened this PR and pushed some tweaks.

Pieces of advice:

Thank you so much for the advice. I'm new to open source contribution and this is my first project. I'll keep these things in mind for next time.

@lesteve
Copy link
Member

lesteve commented Feb 19, 2022

Merging, thanks a lot!

@lesteve lesteve changed the title Updated the plot_svm_regression.py file DOC: use notebook-style for plot_svm_regression.py example Feb 19, 2022
@lesteve lesteve merged commit 6016083 into scikit-learn:main Feb 19, 2022
@lesteve lesteve mentioned this pull request Feb 21, 2022
47 tasks
thomasjpfan pushed a commit to thomasjpfan/scikit-learn that referenced this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants