DOC updated to notebook style for grid_search_text_feature_extraction.py #22558
Conversation
| # Load categories from the training set | ||
| # ------------------------------------- |
There was a problem hiding this comment.
I think this two lines are misplaced, as right below we have all the imports and no training set has been defined. I would keep them in their original position.
There was a problem hiding this comment.
In other accepted pull requests they put the first head above the imports but below the authors, so I put it here to stay consistent with the other pull requests.
examples/model_selection/grid_search_text_feature_extraction.py
Outdated
Show resolved
Hide resolved
| # Grid Search | ||
| # ----------- |
There was a problem hiding this comment.
Maybe splitting this as a new cell is not really necessary if my previous comment is taken into account, what do you think?
There was a problem hiding this comment.
Yeah I agree. I kept it because it was there previously, but I don't think it is needed
Changed header Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
examples/model_selection/grid_search_text_feature_extraction.py
Outdated
Show resolved
Hide resolved
…nto example-notebook-style
|
I pushed a few tweaks, pulled upstream/main into your branch (because the doc-min-dependencies was failing). This looks good now, merging, thanks a lot! |
….py (scikit-learn#22558) Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com> Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Reference Issues/PRs
Updated notebook style for
examples/model_selection/grid_search_text_feature_extraction.py. Related to #22406What does this implement/fix? Explain your changes.
Split example into
Any other comments?
Can I make edits to the code to make it more clear?