Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: use notebook-style for plot_pca_3d.py #23064

Merged
merged 3 commits into from
Apr 8, 2022
Merged

Conversation

nat-salt
Copy link
Contributor

@nat-salt nat-salt commented Apr 6, 2022

Reference Issues/PRs

Fixes plot_pca_3d.py for #22406

What does this implement/fix? Explain your changes.

This updates plot_pca_3d.py to notebook style used in other examples

Any other comments?

@lesteve lesteve added the Quick Review For PRs that are quick to review label Apr 7, 2022
@lesteve lesteve mentioned this pull request Apr 7, 2022
47 tasks
@lesteve
Copy link
Member

lesteve commented Apr 8, 2022

The doc-min-dependencies build is failing. It looks like with the min matplotlib version you need to import import mpl_toolkits.mplot3d #22594 (comment)

@lesteve
Copy link
Member

lesteve commented Apr 8, 2022

I pushed some tweaks:

  • use underline of the right length
  • move imports in the cell they are first used
  • fix for matplotlib 3.1 mentioned in the previous comment

@lesteve lesteve changed the title updated plot_pca_3d.py DOC: use notebook-style for plot_pca_3d.py Apr 8, 2022
@lesteve
Copy link
Member

lesteve commented Apr 8, 2022

Merging, thanks a lot!

@lesteve lesteve merged commit fbc56ed into scikit-learn:main Apr 8, 2022
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Apr 29, 2022
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Quick Review For PRs that are quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants