DEP: linalg: deprecate kron #21633
Merged
DEP: linalg: deprecate kron #21633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
scipy.linalg
deprecated
Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>
j-bowhay
added
the
needs-release-note
|
doctest failure is real |
There was a problem hiding this comment.
For the doctest failure, this seems to do the trick locally (a bit silly, though I suppose it makes the deprecation even harder to miss...). Maybe Evgeni has a slicker way to suppress the failure.
--- a/scipy/linalg/_special_matrices.py
+++ b/scipy/linalg/_special_matrices.py
@@ -337,9 +337,12 @@ def kron(a, b):
Examples
--------
+ >>> import warnings
>>> from numpy import array
>>> from scipy.linalg import kron
- >>> kron(array([[1,2],[3,4]]), array([[1,1,1]]))
+ >>> with warnings.catch_warnings():
+ ... warnings.simplefilter("ignore", DeprecationWarning)
+ ... kron(array([[1,2],[3,4]]), array([[1,1,1]]))
array([[1, 1, 1, 2, 2, 2],
[3, 3, 3, 4, 4, 4]])
|
There's a DeprecationWarning filter for doctests in https://github.com/scipy/scipy/blob/main/scipy/conftest.py#L382-L389, if you want to use that. |
|
thanks Jake! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
closes #20077
closes #20072
What does this implement/fix?
This was previously blocked by array-api discussions however now with data-apis/array-api-extra#7 I think we can now proceed.
Additional information