ENH: BLD: allow building OpenBLAS from source in a SciPy wheel #22047
+51
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommers
added
enhancement
Implements the feature suggested in scipy#21396. Requires a fix for meson-python#711 still and that fix being released in a new meson-python version. Until that is done, the problem can be worked around easily for testing purposes with: `LD_LIBRARY_PATH=/path/to/site-packages/scipy/special`. [ci skip]
rgommers
force-pushed
the
openblas-src-wheel
branch
from
06e7284 to
64ed6e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Closes gh-21396
What does this implement/fix?
Implements the feature suggested in gh-21396. See #21396 (comment) for a detailed rationale.
Improves the error message for the all-too-common " ERROR: Dependency "openblas" not found" end to an build attempt. There are 72 issues with that message currently, with gh-16308 the most high-traffic recent one.
Additional information
Passes all tests for me on Linux x86-64 and macOS arm64.
Requires a fix for meson-python#711 still and that fix being released in a new
meson-pythonversion. Until that is done, the problem can be worked around for testing purposes with:LD_LIBRARY_PATH=/path/to/site-packages/scipy/special.Opening the PR as draft now to support the discussion in gh-21396. It's ~20 lines of code, and that's as concise as it should stay (unless we want to add a CI job here rather than in a separate repo - but happy to keep it separate for now). All the complexity to support this is part of other repos.
Also, the
highssubproject hasn't given us any problems so far, which is nice.openblaswill be the second subproject; more may follow after (xref gh-17751).