Referer Regex #1862
Merged
Referer Regex #1862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dash is not necessary for production use, but for tests.
jakobvogel
added
🐛 Bugfix
mko-sci
approved these changes
Oct 25, 2023
sabieber
approved these changes
Oct 25, 2023
jmuscireum
approved these changes
Oct 25, 2023
idlira
approved these changes
Oct 25, 2023
| @@ -705,7 +705,7 @@ protected void redirectToSaneReferer(final WebContext webContext, Pattern patter | |||
| * @see #redirectToSaneReferer(WebContext, Pattern, String) | |||
| */ | |||
| protected static Pattern createPatternForOverviewAndDetailRoutes(String overviewRoute, String detailRoutePrefix) { | |||
| return Pattern.compile("^(" + Pattern.quote(detailRoutePrefix) + "\\w+|" + Pattern.quote(overviewRoute) + ")$"); | |||
| return Pattern.compile("^(" + Pattern.quote(detailRoutePrefix) + "[0-9a-zA-Z_\\-]+|" + Pattern.quote(overviewRoute) + ")$"); | |||
There was a problem hiding this comment.
/user-accounts is a biz route using a dash 😇
There was a problem hiding this comment.
I am not talking about generic routes, but routes using identifiers or counters. These are AFAIK usually restricted to even A-Z0-9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The dash is not necessary for production use, but for tests.
Checklist