Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING - Revamps the kb tags 'toc' and 'tocEntry'/'tocLink' #1870

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

mko-sci
Copy link
Contributor

@mko-sci mko-sci commented Nov 10, 2023

  • ...breaking since it will change the layout of the current toc's as they are not in an individual section anymore
  • ...breaking since 'tocEntry' got renamed to 'tocLink'

What to do?

  • ...wrap existing <k:toc> blocks into a <i:block name="sidebar"> -> makes the toc appear in the side bar.
  • ...rename <k:tocEntry> to <k:tocLink>.

Checklist

  • Code change has been tested and works locally
  • Code was formatted via IntelliJ and follows SonarLint & best practices

...breaking since it will change the layout of the current toc's as they are not in an individual section anymore

Fixes: SIRI-890
 ...to better reflect its purpose

Fixes: SIRI-890
@mko-sci mko-sci added 🧬 Enhancement Contains new features 👶🏻 Trivial Easy to review 💣 BREAKING CHANGE Contains non-backwards compatible changes to public methods or changes the behavior of existing code 🛠️ Maintenance Translations, Code Cleanup, ... labels Nov 10, 2023
Copy link
Member

@sabieber sabieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for listing a migration guide 👍🏻

@mko-sci mko-sci merged commit d662ca2 into develop Nov 13, 2023
@mko-sci mko-sci deleted the feature/mko/SIRI-890-2 branch November 13, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💣 BREAKING CHANGE Contains non-backwards compatible changes to public methods or changes the behavior of existing code 🧬 Enhancement Contains new features 🛠️ Maintenance Translations, Code Cleanup, ... 👶🏻 Trivial Easy to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants