Junit: Migrate objectstoretest to kotlin #1879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeckmkeck
reviewed
Nov 17, 2023
mko-sci
approved these changes
Nov 17, 2023
mkeckmkeck
reviewed
Nov 17, 2023
mkeckmkeck
approved these changes
Nov 20, 2023
sabieber
approved these changes
Nov 20, 2023
| import kotlin.test.assertFalse | ||
|
|
||
| @ExtendWith(SiriusExtension::class) | ||
| class ObjectStoresTest { |
There was a problem hiding this comment.
Small KDoc mentioning the class that is being tested?
| class ObjectStoresTest { | ||
|
|
||
| @Test | ||
| fun `createBucketWorks`() { |
There was a problem hiding this comment.
Maybe use the capabilities of Kotlin here with method names that can include spaces so the test case description is a bit more readable.
sabieber
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates objectstoretest to kotlin