Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KB - Filters out templates which are inside a parent directory with the name "parts" or inside the path "kb/parts" #1893

Merged
merged 4 commits into from
Nov 28, 2023
Merged

KB - Filters out templates which are inside a parent directory with the name "parts" or inside the path "kb/parts" #1893

merged 4 commits into from
Nov 28, 2023

Conversation

mko-sci
Copy link
Contributor

@mko-sci mko-sci commented Nov 28, 2023 •
edited
Loading

Additional Notes

Checklist

  • Code change has been tested and works locally
  • Code was formatted via IntelliJ and follows SonarLint & best practices

@mko-sci mko-sci changed the title Filters out templates which are inside a part directory KB - Filters out templates which are inside a part directory Nov 28, 2023
@mko-sci mko-sci added 👶🏻 Trivial Easy to review 🧬 Enhancement Contains new features labels Nov 28, 2023
@mko-sci mko-sci changed the title KB - Filters out templates which are inside a part directory KB - Filters out templates which are inside a parent directory with the name "parts" or inside the path "kb/parts" Nov 28, 2023
@mko-sci mko-sci requested a review from andyHa November 28, 2023 13:22
@mko-sci @fhaScireum
Simplifies filter
8eb88ed 
Co-authored-by: Florian Häfner <53555813+fhaScireum@users.noreply.github.com>
@mko-sci mko-sci merged commit ca2df08 into develop Nov 28, 2023
2 checks passed
@mko-sci mko-sci deleted the feature/mko/OX-10557-3 branch November 28, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabieber sabieber sabieber approved these changes

@bkositza bkositza bkositza approved these changes

@mkeckmkeck mkeckmkeck mkeckmkeck approved these changes

@idlira idlira idlira approved these changes

@fhaScireum fhaScireum fhaScireum approved these changes

@andyHa andyHa Awaiting requested review from andyHa

Assignees
No one assigned
Labels
🧬 Enhancement Contains new features 👶🏻 Trivial Easy to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mko-sci @andyHa @sabieber @fhaScireum @idlira @mkeckmkeck @bkositza