Bootstrap 5 #1934
Merged
Bootstrap 5 #1934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In general, Bootstrap 5 replaced `left` with `start` and `right` with `end`, in order to support Right-to-Left languages. Also includes further adaptions. See https://getbootstrap.com/docs/5.0/migration/. SIRI-925
SIRI-925
The name has used twice. Charts could no longer be closed. SIRI-933
Introduced margin that is no longer implied, added compulsory groups to labels. SIRI-925
Wrapping appendices to inputs is no longer required in BS 5. SIRI-925
SIRI-925
SIRI-925
Links are underlined, jQuery removed. SIRI-925
SIRI-925
SIRI-925
jakobvogel
added
🖐 Keep open
SIRI-925
Lists must not contain links directly, but they must reside within list items. SIRI-925
The component makes assumptions about the inner workings of Bootstrap that are no longer met by version 5. It turns out that changing the tabs via the drop-down menu (as happens if there are more than 4 languages) does not work initially, due to a conflicting inner state between ourselves and bootstrap. For now, this can be solved by simulating a click on the entry for the selected language. This will bring the states into synch. SIRI-925
SIRI-925
The toggle must not be set in this case! SIRI-925
sabieber
reviewed
Feb 10, 2024
sabieber
reviewed
Feb 12, 2024
src/main/resources/default/templates/biz/tycho/kb/welcome_de.html.pasta
Outdated
Show resolved
Hide resolved
fhaScireum
approved these changes
Feb 13, 2024
Thanks for checking 👍🏻 Did not check it myself, just saw that the file is in a generic scripts package and not in a tycho package. |
ymo-sci
reviewed
Feb 13, 2024
ymo-sci
reviewed
Feb 13, 2024
idlira
approved these changes
Feb 13, 2024
This commit uses a new key introduced in scireum/sirius-web@c58dec1. SIRI-925
SIRI-925
The file is never directly loaded but invoked via another template. SIRI-925
As proposed by @sabieber, we can reuse the link element instead of manually replicating the link syntax multiple times. SIRI-925
SIRI-925
ymo-sci
approved these changes
Feb 13, 2024
sabieber
approved these changes
Feb 14, 2024
SIRI-925
jakobvogel
removed
the
🕔 Wait for sirius
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ports Tycho to Bootstrap 5.
Additional Notes
Checklist