Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to use input pattern for SAML fingerprint instead of js script tag #1947

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Changes to use input pattern for SAML fingerprint instead of js script tag #1947

merged 3 commits into from
Feb 29, 2024

Conversation

scireum-mbo
Copy link
Contributor

Additional Notes

Checklist

  • Code change has been tested and works locally
  • Code was formatted via IntelliJ and follows SonarLint & best practices
  • Patch Tasks: Is local execution of Patch Tasks necessary? If so, please also mark the PR with the tag.

@scireum-mbo scireum-mbo added 👶🏻 Trivial Easy to review 🧬 Enhancement Contains new features labels Feb 28, 2024
sabieber
sabieber approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@sabieber sabieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be even better to add an optional pattern parameter to t:textfield

@scireum-mbo scireum-mbo added the 🕔 Wait for sirius Needs new version from another sirius lib to work label Feb 28, 2024
@scireum-mbo scireum-mbo removed the 🕔 Wait for sirius Needs new version from another sirius lib to work label Feb 28, 2024
idlira
idlira approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@idlira idlira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update the pom!

@scireum-mbo scireum-mbo merged commit 6c24e35 into develop Feb 29, 2024
2 checks passed
@scireum-mbo scireum-mbo deleted the feature/mbo/OX-10835 branch February 29, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mko-sci mko-sci mko-sci approved these changes

@mkeckmkeck mkeckmkeck mkeckmkeck approved these changes

@ymo-sci ymo-sci ymo-sci approved these changes

@idlira idlira idlira approved these changes

@fhaScireum fhaScireum fhaScireum approved these changes

@sabieber sabieber sabieber approved these changes

Assignees
No one assigned
Labels
🧬 Enhancement Contains new features 👶🏻 Trivial Easy to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@scireum-mbo @sabieber @fhaScireum @idlira @ymo-sci @mkeckmkeck @mko-sci