Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KBA: Fixes links not opening in new tab in OXOMI KBAs #1963

Merged
merged 4 commits into from
Apr 8, 2024
Merged

KBA: Fixes links not opening in new tab in OXOMI KBAs #1963

merged 4 commits into from
Apr 8, 2024

Conversation

scireum-mbo
Copy link
Contributor

Additional Notes

  • This PR fixes or works on following ticket(s): OX-10926

Checklist

  • Code change has been tested and works locally
  • Code was formatted via IntelliJ and follows SonarLint & best practices
  • Patch Tasks: Is local execution of Patch Tasks necessary? If so, please also mark the PR with the tag.

@scireum-mbo scireum-mbo added 🛠️ Maintenance Translations, Code Cleanup, ... 🐛 Bugfix Contains only a small fix for an existing bug and removed 🛠️ Maintenance Translations, Code Cleanup, ... labels Apr 4, 2024
jakobvogel
jakobvogel approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@jakobvogel jakobvogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format properly without single-word-lines.

src/main/resources/default/kb/en/user/tagliatelle.html.pasta Outdated Show resolved Hide resolved
src/main/resources/default/kb/en/user/tagliatelle.html.pasta Outdated Show resolved Hide resolved
@scireum-mbo scireum-mbo merged commit 484a57b into develop Apr 8, 2024
3 checks passed
@scireum-mbo scireum-mbo deleted the feature/mbo/OX-10926 branch April 8, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkeckmkeck mkeckmkeck mkeckmkeck approved these changes

@idlira idlira idlira approved these changes

@jakobvogel jakobvogel jakobvogel approved these changes

@sabieber sabieber sabieber approved these changes

Assignees
No one assigned
Labels
🐛 Bugfix Contains only a small fix for an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@scireum-mbo @sabieber @jakobvogel @idlira @mkeckmkeck