-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tenant Scripting Enhancements #1964
Conversation
Fixes: OX-9839
Fixes: OX-9839
Fixes: OX-9839
ensuring its loading the latest state of scripts Fixes: OX-9839
enableScriptableEvents must be overwritten so scripting takes effect. If active, and only one script exists, the parameter is collected hidden and the first entry will be the default one. This also provides better tracking to which dispatcher was actually used (even a hidden one) since the parameter and its value is logged at job start. Fixes: OX-9839
src/main/resources/default/templates/biz/scripting/mongo-scripts.html.pasta
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The usual question: The use of ne
constraints does not have adverse effects in terms of DB performance and the use of a search index?
src/main/java/sirius/biz/scripting/mongo/MongoCustomScriptController.java
Outdated
Show resolved
Hide resolved
src/main/java/sirius/biz/scripting/mongo/MongoCustomScriptController.java
Outdated
Show resolved
Hide resolved
Fixes: OX-9839
Co-authored-by: Jakob Vogel <jvo@scireum.de>
Should not. In fact the new field is not even in the index, I will add it... |
and changes queries to use $eq instead of $ne. Since the entity is new, there is no need to resave them unless in a few local systems Fixes: OX-9839
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏
Fixes: OX-9839
Fixes: OX-9839
Fixes: OX-9839
Description
ImportBatchProcessFactory.enableScriptableEvents
method. For this to work, we changed the magic detection logic when only one script exists: with the feature disabled, no parameter is collected, thus the NOOP_DISPATCHER is used. If the parameter is collected but contains only one single entry, its hidden by default. One of the main advantages is, that even for hidden parameters the job will log the default script used during its initialization, eg:Additional Notes
Checklist