Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DH-240: Fix the SelectStringParameter.getValues() method. #1982

Merged
merged 2 commits into from
Apr 25, 2024
Merged

DH-240: Fix the SelectStringParameter.getValues() method. #1982

merged 2 commits into from
Apr 25, 2024

Conversation

oolscireum
Copy link
Contributor

Description

Modifies the SelectStringParameter.getValues() method to use fetchEntriesMap() only one single time.

Additional Notes

  • This PR fixes or works on following ticket(s): DH-240

Checklist

  • Code change has been tested and works locally
  • Code was formatted via IntelliJ and follows SonarLint & best practices
  • Patch Tasks: Is local execution of Patch Tasks necessary? If so, please also mark the PR with the tag.

@oolscireum
Modifies the getValues() method to use fetchEntriesMap() only one sin…
7461f64 
…gle time.

This is needed when entries provider calls the database.
The repeated call of fetchEntriesMap() causes multiple database calls and a long wait time because of that.

Fixes: DH-240
@oolscireum oolscireum added 🐛 Bugfix Contains only a small fix for an existing bug 👶🏻 Trivial Easy to review labels Apr 24, 2024
mkeckmkeck
mkeckmkeck reviewed Apr 24, 2024
View reviewed changes
Copy link
Contributor

@mkeckmkeck mkeckmkeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename entry to key or stream the entryset

@oolscireum oolscireum merged commit fef7219 into develop Apr 25, 2024
3 checks passed
@oolscireum oolscireum deleted the feature/ool/DH-240 branch April 25, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkeckmkeck mkeckmkeck mkeckmkeck approved these changes

@ymo-sci ymo-sci ymo-sci approved these changes

@fhaScireum fhaScireum fhaScireum approved these changes

@sabieber sabieber Awaiting requested review from sabieber

Assignees
No one assigned
Labels
🐛 Bugfix Contains only a small fix for an existing bug 👶🏻 Trivial Easy to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oolscireum @sabieber @fhaScireum @ymo-sci @mkeckmkeck