Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce new permission to use the open-search and fix some related problems #1992

Merged
merged 9 commits into from
May 15, 2024
Merged

Introduce new permission to use the open-search and fix some related problems #1992

merged 9 commits into from
May 15, 2024

Conversation

ymo-sci
Copy link
Contributor

@ymo-sci ymo-sci commented May 15, 2024 •
edited
Loading

Description

  • add category-links to templates
  • fix security-sandbox restrictions
  • fix texts in /kb welcome page and adjust them with the new permission
  • switch order of user-accounts and tenants in search-results
Bildschirmfoto 2024-05-15 um 09 03 48

Additional Notes

  • This PR fixes or works on following ticket(s): SE-13658
  • This PR is related to PR:

Checklist

  • Code change has been tested and works locally
  • Code was formatted via IntelliJ and follows SonarLint & best practices
  • Patch Tasks: Is local execution of Patch Tasks necessary? If so, please also mark the PR with the tag.

ymo-sci added 5 commits May 15, 2024 08:13
@ymo-sci
introduce permission for tycho-open-search
b3a688b 
- fixes: SE-13658
@ymo-sci
use new permission and adjust text/fix wrong wording
7a9d4f6 
the link was displayed independent of the active framework tycho.open-search until now

- fixes: SE-13658
@ymo-sci
autoformat and fix typo
fc8b197 
- fixes: SE-13658
@ymo-sci
fix rendering the templates created in openSearchProviders.
35d756f 
the security-sandbox crashed the rendering of the tenant/select links so we disable it here.

- fixes: SE-13658
@ymo-sci
add missing category-links to the open-search result page
7e863ea 
they were collected but never used until now

- fixes: SE-13658
@ymo-sci ymo-sci added 🧬 Enhancement Contains new features 🐛 Bugfix Contains only a small fix for an existing bug labels May 15, 2024
@sabieber
Copy link
Member

sabieber commented May 15, 2024 •
edited
Loading

In regards to design i think an external link icon next to the plain section title would look cleaner and would not draw away focus from the card as much. The section titles are really prominent now.

idlira
idlira reviewed May 15, 2024
View reviewed changes
Copy link
Contributor

@idlira idlira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we go with smaller fonts for the main category so they don't look so huge?

We also have a user-wish to show Tenants before Users. If that's OK, could we also tacke it here?

@ymo-sci
Copy link
Contributor Author

ymo-sci commented May 15, 2024

Could we go with smaller fonts for the main category so they don't look so huge?

We also have a user-wish to show Tenants before Users. If that's OK, could we also tacke it here?

So that "Jobs" is smaller?

  • i´ll check it both.

@ymo-sci ymo-sci requested a review from idlira May 15, 2024 07:03
@idlira idlira merged commit 87eec8c into develop May 15, 2024
3 checks passed
@idlira idlira deleted the feature/ymo/open-search branch May 15, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mko-sci mko-sci mko-sci approved these changes

@idlira idlira idlira approved these changes

@fhaScireum fhaScireum fhaScireum approved these changes

@sabieber sabieber sabieber approved these changes

Assignees
No one assigned
Labels
🐛 Bugfix Contains only a small fix for an existing bug 🧬 Enhancement Contains new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ymo-sci @sabieber @fhaScireum @idlira @mko-sci