Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: Show num rows and limit as info #1999

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Conversation

sabieber
Copy link
Member

@sabieber sabieber commented May 24, 2024

Description

And also move it to above the list, to make it more accessible.

image

image

image

Checklist

  • Code change has been tested and works locally
  • Code was formatted via IntelliJ and follows SonarLint & best practices
  • Patch Tasks: Is local execution of Patch Tasks necessary? If so, please also mark the PR with the tag.

sabieber added 2 commits May 24, 2024 13:40
And also move it to above the list, to make it more accessible.
@sabieber sabieber added 🧬 Enhancement Contains new features 👶🏻 Trivial Easy to review labels May 24, 2024
This makes it easier to keep track when a lot of columns are printed
Copy link
Contributor

@ymo-sci ymo-sci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it is limited to 1000, but more than 1000 results, shouldn't we print out
"xxxx (limited to 1000) here" ?

@fhaScireum
Copy link
Contributor

if it is limited to 1000, but more than 1000 results, shouldn't we print out "xxxx (limited to 1000) here" ?

Or we could show e.g. "24 rows" without hinting at the limit as it is superflous and if we reach the 1000 result, show "1000 rows (reached row limit)" or something similar.

@sabieber
Copy link
Member Author

We can't know if we exactly hit the limit or are over it and rows are truncated without some logic in the controller/query that queries limit + 1 and then omits the last row, etc.

As this was just a nice to have improvement I tried to keep it simple, but if enough of you want this I can implement it.

@idlira idlira merged commit f11bb4a into develop Jun 4, 2024
3 checks passed
@idlira idlira deleted the feature/sbi/sql-row-count branch June 4, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧬 Enhancement Contains new features 👶🏻 Trivial Easy to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants