Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds comment for results on SQL-performance regarding countIf- and GROUPBY-queries to framework #2001

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Adds comment for results on SQL-performance regarding countIf- and GROUPBY-queries to framework #2001

merged 2 commits into from
Jun 3, 2024

Conversation

scireum-mbo
Copy link
Contributor

Additional Notes

Checklist

  • Code change has been tested and works locally
  • Code was formatted via IntelliJ and follows SonarLint & best practices
  • Patch Tasks: Is local execution of Patch Tasks necessary? If so, please also mark the PR with the tag.

@scireum-mbo scireum-mbo added 🧬 Enhancement Contains new features 👶🏻 Trivial Easy to review labels May 28, 2024
sabieber
sabieber approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@sabieber sabieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: Would suggest moving it up into the JavaDoc (with a <p> between the first line and the new sentence. This way its also visible when invoking the quick docs (F1) where the method is called.

@scireum-mbo scireum-mbo merged commit 74e00d1 into develop Jun 3, 2024
3 checks passed
@scireum-mbo scireum-mbo deleted the feature/mbo/OX-11019 branch June 3, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idlira idlira idlira approved these changes

@sabieber sabieber sabieber approved these changes

Assignees
No one assigned
Labels
🧬 Enhancement Contains new features 👶🏻 Trivial Easy to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scireum-mbo @sabieber @idlira