Implements versioned files for sirius biz #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables us to version e.g. javascript written jobs - Fixes: SE-4561
andyHa
reviewed
Nov 6, 2018
| /** | ||
| * Entity holding meta information about a versioned file. | ||
| */ | ||
| @Explain("No need to override the equals method. Mapping and property can have the same name, this is sirius standard.") |
There was a problem hiding this comment.
check settings - this should be suppressed anyway
LunaBytesBack
suggested changes
Nov 8, 2018
| /** | ||
| * Entity holding meta information about a versioned file. | ||
| */ | ||
| public class VersionedFile extends SQLTenantAware { |
There was a problem hiding this comment.
check via storage framework if active?
There was a problem hiding this comment.
still add a @framework(XXX) here so that the table isn't created if the framework isn't active.
also - shoudln't we move all this into a sub-package "versions" to not confuse it with VirtualObjectVersion(s)
LunaBytesBack
approved these changes
Nov 8, 2018
this prevents the table from being created if the framwork is not active
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables us to version e.g. javascript written jobs