SIRI-989: File Storage – Fix Duplicate Listing of Files and incorrect Total Count for Pagination #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he current page. The start is expected to be 1 for the first page, and 25 for the second if page size is 24. However, Limit#getItemsToSkip returns 0 for the first page and 24 for the second page. As a start value lower than 1 is ignored, this bug had no impact on the first page. Fixes: SIRI-989
Generally, pages fetch the count of entries based on their base query. However, here, the base query does only consider SQLBlob / MongoBlob and not SQLDirectory / MongoDirectory. Therefore, the count has to be resolved manually when directories are part of the result set. Fixes: SIRI-989
idlira
approved these changes
Jul 12, 2024
mkeckmkeck
approved these changes
Jul 12, 2024
mko-sci
approved these changes
Jul 12, 2024
ymo-sci
approved these changes
Jul 12, 2024
jakobvogel
approved these changes
Jul 12, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If directories are present, the total count can't just be calculated based on the number of SQLBlob / MongoBlob entities. While fixing this, a second bug emerged: The last file of a page is also listed as the first file of the next one.
Additional Notes
Checklist