Bumps sirius-biz and applies breaking changes #2064
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: SIRI-1039
Fixes: SIRI-1039
idlira
added
💣 BREAKING CHANGE
sabieber
reviewed
Dec 16, 2024
| @@ -109,7 +109,7 @@ public class SQLVariant extends SQLEntity implements BlobVariant { | |||
|
|
|||
| @AfterDelete | |||
| protected void onDelete() { | |||
| SQLBlob sqlBlob = sourceBlob.fetchValue(); | |||
| SQLBlob sqlBlob = sourceBlob.fetchCachedValue(); | |||
There was a problem hiding this comment.
Question: Doesn't use of the ref-cache here potentially lead to trying to delete a blob that may be already deleted otherwise?
There was a problem hiding this comment.
True, will review the places.
| @@ -181,7 +181,7 @@ protected List<T> querySAMLTenants() { | |||
|
|
|||
| private void verifyUser(SAMLResponse response, UserInfo user) { | |||
| U account = user.getUserObject(getUserClass()); | |||
| T tenant = account.getTenant().fetchValue(); | |||
| T tenant = account.getTenant().fetchCachedValue(); | |||
There was a problem hiding this comment.
Question: Wouldn't it be better to use the cache of the Tenants part here?
There was a problem hiding this comment.
It is. Extrapolates the purpose of the change/ticket though which requires additional/special testing.
| @@ -407,7 +407,7 @@ public void selectTenant(final WebContext webContext, String tenantId) { | |||
| .causedByUser(account.getUniqueName(), account.getUserAccountData().getLogin().getUsername()) | |||
| .forUser(account.getUniqueName(), account.getUserAccountData().getLogin().getUsername()) | |||
| .forTenant(account.getTenant().getIdAsString(), | |||
| account.getTenant().fetchValue().getTenantData().getName()) | |||
| account.getTenant().fetchCachedValue().getTenantData().getName()) | |||
| @@ -453,7 +453,7 @@ public UserInfo findUserByName(@Nullable WebContext webContext, String user) { | |||
| U account = optionalAccount.get(); | |||
|
|
|||
| userAccountCache.put(account.getUniqueName(), account); | |||
| tenantsCache.put(account.getTenant().fetchValue().getIdAsString(), account.getTenant().fetchValue()); | |||
| tenantsCache.put(account.getTenant().fetchCachedValue().getIdAsString(), account.getTenant().fetchCachedValue()); | |||
There was a problem hiding this comment.
Don't think its a good idea to fill a cache with a cached value
| @@ -569,7 +569,8 @@ protected U fetchAccount(@Nonnull String accountId) { | |||
| return null; | |||
| } | |||
| userAccountCache.put(account.getUniqueName(), account); | |||
| tenantsCache.put(account.getTenant().fetchValue().getIdAsString(), account.getTenant().fetchValue()); | |||
| tenantsCache.put(account.getTenant().fetchCachedValue().getIdAsString(), | |||
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Marking as BREAKING since this applies a breaking change from sirius-biz.
Additional Notes
Checklist