Job for reindexing elastic indexes & move index aliases #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the reindex API available
andyHa
requested changes
Feb 15, 2019
| @Override | ||
| protected void collectParameters(Consumer<Parameter<?, ?>> parameterCollector) { | ||
| if (stringParameter == null) { | ||
| stringParameter = new StringParameter("destination", NLS.get("MoveIndexAliasJobFactory.destinationParameter")); |
There was a problem hiding this comment.
do not cache the parameter here, as NLS.get is dependent on the user locale - so the first user would determine the parameter name for all successive calls
There was a problem hiding this comment.
simply use collector.accept(new StringParameter(...).markRequired())
There was a problem hiding this comment.
or even better - initialize the fields directly and uses a constant for label as it will be auto translated
| @Override | ||
| protected void collectParameters(Consumer<Parameter<?, ?>> parameterCollector) { | ||
| if (entityDescriptorParameter == null) { | ||
| entityDescriptorParameter = new ElasticEntityDescriptorParameter("ed", NLS.get("ReindexJobFactory.descriptorParameter")); |
andyHa
reviewed
Feb 15, 2019
| private Elastic elastic; | ||
|
|
||
| private ElasticEntityDescriptorParameter entityDescriptorParameter = null; | ||
| private StringParameter stringParameter = null; |
There was a problem hiding this comment.
Suggested change
| private StringParameter stringParameter = null; | |
| private StringParameter stringParameter = new StringParameter("destination", "MoveIndexAliasJobFactory.destinationParameter"); |
andyHa
reviewed
Feb 15, 2019
| @Part | ||
| private Elastic elastic; | ||
|
|
||
| private ElasticEntityDescriptorParameter entityDescriptorParameter = null; |
There was a problem hiding this comment.
Suggested change
| private ElasticEntityDescriptorParameter entityDescriptorParameter = null; | |
| private ElasticEntityDescriptorParameter entityDescriptorParameter = new ElasticEntityDescriptorParameter("ed", "MoveIndexAliasJobFactory.descriptorParameter").markRequired(); |
andyHa
reviewed
Feb 15, 2019
| * Implements a job which reindexes a given index in elastic. | ||
| */ | ||
| @Register(classes = JobFactory.class) | ||
| public class ReindexJobFactory extends BatchProcessJobFactory { |
There was a problem hiding this comment.
@Permission(TenantUserManager.PERMISSION_SYSTEM_TENANT)
andyHa
reviewed
Feb 15, 2019
|
|
||
| @Override | ||
| public String getCategory() { | ||
| return "MAINTENANCE"; |
andyHa
requested changes
Feb 18, 2019
| (ElasticEntityDescriptorParameter) new ElasticEntityDescriptorParameter("ed", | ||
| "$MoveIndexAliasJobFactory.descriptorParameter") | ||
| .markRequired(); | ||
| private StringParameter stringParameter = |
|
|
||
| @Override | ||
| protected String createProcessTitle(Map<String, String> context) { | ||
| return "MoveIndexAlias"; |
There was a problem hiding this comment.
something like Strings.apply("Movin Elasticsearch Index %s to %s, ....) - would be very nice
|
|
||
| @Override | ||
| protected String createProcessTitle(Map<String, String> context) { | ||
| return "Reindex"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.