Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves startup issues caused by upgrading the Clickhouse dependencies #657

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Resolves startup issues caused by upgrading the Clickhouse dependencies #657

merged 4 commits into from
Jun 4, 2024

Conversation

idlira
Copy link
Contributor

@idlira idlira commented Jun 4, 2024 •
edited
Loading

Description

Resolves startup issues caused by the related PR.
Downgrading the server-version is not necessary.

Additional Notes

Checklist

  • Code change has been tested and works locally
  • Code was formatted via IntelliJ and follows SonarLint & best practices

idlira added 3 commits June 4, 2024 13:51
@idlira
Downgrade Clickhouse lib to 0.4.6
343e7a6 
versions above are too buggy. This one solves the security issues reported by our dependabot.

Fixes: SIRI-888
@idlira
Suppress a startup warning
29ca1e2 
The clickhouse lib wants slf4j 1.7.x and complains that no logger has been chosen. There is though a noop one we can use.

Fixes: SIRI-888
@idlira
Removes obsolete version number
811c2e5 
Fixes: SIRI-888
@idlira idlira added 👶🏻 Trivial Easy to review 🛠️ Maintenance Translations, Code Cleanup, ... labels Jun 4, 2024
@idlira idlira changed the title ili/SIRI-888 Resolves startup issues caused by upgrading the Clickhouse dependencies Jun 4, 2024
@idlira idlira added the 🐛 Bugfix Contains only a small fix for an existing bug label Jun 4, 2024
mkeckmkeck
mkeckmkeck reviewed Jun 4, 2024
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
@idlira idlira added ⬆️ Dependencies Pull requests that update a dependency file and removed 🛠️ Maintenance Translations, Code Cleanup, ... labels Jun 4, 2024
@idlira idlira merged commit 892f087 into develop Jun 4, 2024
5 checks passed
@idlira idlira deleted the ili/SIRI-888 branch June 4, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkeckmkeck mkeckmkeck mkeckmkeck approved these changes

@sabieber sabieber sabieber approved these changes

Assignees
No one assigned
Labels
🐛 Bugfix Contains only a small fix for an existing bug ⬆️ Dependencies Pull requests that update a dependency file 👶🏻 Trivial Easy to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@idlira @sabieber @mkeckmkeck