Sorts component conf files in the correct order #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These need to be reversed as `withFallback` is used for each config. This means that only properties that are missing in the first one are taken from the second one and so on. Fixes: SIRI-891
sabieber
added
🐛 Bugfix
jakobvogel
approved these changes
Oct 16, 2023
idlira
approved these changes
Oct 16, 2023
mko-sci
approved these changes
Oct 16, 2023
mkeckmkeck
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These need to be reversed as
withFallbackis used for each config. This means that only properties that are missing in the first one are taken from the second one and so on.Fixes: SIRI-891