Files: Implements methods isHidden and isMetadata to check if a path is either hidden or a type of metadata file #544

scireum-mbo · 2024-12-10T09:20:45Z

Additional Notes

This PR fixes or works on following ticket(s): SIRI-1028
This PR is related to PR: Fixes system-files not being ignored by ZIP-native extractor when executing an import-job sirius-biz#2059

Checklist

Code change has been tested and works locally
Code was formatted via IntelliJ and follows SonarLint & best practices
Patch Tasks: Is local execution of Patch Tasks necessary? If so, please also mark the PR with the tag.

Fixes: SIRI-1028

…adata file Fixes: SIRI-1028

src/main/java/sirius/kernel/commons/Files.java

This is done because we validate a string and don't use any file-system feature. Fixes: SIRI-1028

idlira

One more note regarding validating longer path.
Perhaps a test case can be added to check these methods.

src/main/java/sirius/kernel/commons/Files.java

… by Windows or MacOS Fixes: SIRI-1028

Fixes: SIRI-1028

… check Fixes: SIRI-1028

This is done, because hidden files can also be inside of folders Fixes: SIRI-1028

src/main/java/sirius/kernel/commons/Files.java

Fixes: SIRI-1028

…n subfolders Unfortunately this decreases search precision due to checking the entire string instead of just the beginning. Fixes: SIRI-1028

Fixes: SIRI-1028

src/main/java/sirius/kernel/commons/Files.java

Also implements a check for an empty string. If the path is empty we return an empty stream Fixes: SIRI-1028

Fixes: SIRI-1028

…mPath Fixes: SIRI-1028

src/main/java/sirius/kernel/commons/Files.java

Fixes: SIRI-1028

scireum-mbo added 2 commits December 10, 2024 10:16

Creates a new list that contains metadata file names and extensions

cff6289

Fixes: SIRI-1028

Implements methods to check whether a file path is hidden or is a met…

f379ec4

…adata file Fixes: SIRI-1028

scireum-mbo added the 🧬 Enhancement Contains new features label Dec 10, 2024

mko-sci approved these changes Dec 10, 2024

View reviewed changes

sabieber approved these changes Dec 10, 2024

View reviewed changes

src/main/java/sirius/kernel/commons/Files.java Outdated Show resolved Hide resolved

idlira requested changes Dec 10, 2024

View reviewed changes

src/main/java/sirius/kernel/commons/Files.java Outdated Show resolved Hide resolved

src/main/java/sirius/kernel/commons/Files.java Outdated Show resolved Hide resolved

src/main/java/sirius/kernel/commons/Files.java Outdated Show resolved Hide resolved

Renames method to contain "considered"

9d9a8c4

This is done because we validate a string and don't use any file-system feature. Fixes: SIRI-1028

idlira requested changes Dec 10, 2024

View reviewed changes

src/main/java/sirius/kernel/commons/Files.java Outdated Show resolved Hide resolved

scireum-mbo added 4 commits December 10, 2024 10:52

Changes list of metadata files to only contain files that are created…

1493a71

… by Windows or MacOS Fixes: SIRI-1028

Adds a contains to check if the hidden file is inside a folder

bb0119a

Fixes: SIRI-1028

Changes metadata check from contains to startsWith for a more precise…

1799a26

… check Fixes: SIRI-1028

Changes check to always look for the last part of the filepath

9940d07

This is done, because hidden files can also be inside of folders Fixes: SIRI-1028

idlira requested changes Dec 10, 2024

View reviewed changes

src/main/java/sirius/kernel/commons/Files.java Outdated Show resolved Hide resolved

src/main/java/sirius/kernel/commons/Files.java Outdated Show resolved Hide resolved

scireum-mbo added 8 commits December 10, 2024 12:19

Implements tests for the new methods

9969325

Fixes: SIRI-1028

Changes Thumbs.db to the correct case

09174a4

Fixes: SIRI-1028

Fixes misaligned text

c347e08

Fixes: SIRI-1028

Changes the startsWith back to contains to check for metadata files i…

c7388a0

…n subfolders Unfortunately this decreases search precision due to checking the entire string instead of just the beginning. Fixes: SIRI-1028

Updates test for the isConsideredMetadata test

5cd36cb

Fixes: SIRI-1028

Adds a method to retrieve all parts of a given path as a stream

c77f07a

Fixes: SIRI-1028

Adapts return logic to implement the newly added method

9fd3c8b

Fixes: SIRI-1028

Formats file accordingly

3fb0896

Fixes: SIRI-1028

mkeckmkeck reviewed Dec 10, 2024

View reviewed changes

src/main/java/sirius/kernel/commons/Files.java Outdated Show resolved Hide resolved

idlira mentioned this pull request Dec 10, 2024

Fixes system-files not being ignored by ZIP-native extractor when executing an import-job scireum/sirius-biz#2059

Merged

3 tasks

scireum-mbo added 5 commits December 10, 2024 14:45

Makes streamPath public to make it accessible to other classes

d616b10

Also implements a check for an empty string. If the path is empty we return an empty stream Fixes: SIRI-1028

Changes testcases to match functionality

dddfa51

Fixes: SIRI-1028

Renames parameter and changes logic to check if the filename is hidden

2bd2043

Fixes: SIRI-1028

Adds a test for the new streamPath method

4e138f5

Fixes: SIRI-1028

Removes empty string check, due to it already being executed in strea…

97f5cf1

…mPath Fixes: SIRI-1028

idlira approved these changes Dec 10, 2024

View reviewed changes

src/main/java/sirius/kernel/commons/Files.java Outdated Show resolved Hide resolved

idlira reviewed Dec 10, 2024

View reviewed changes

src/main/java/sirius/kernel/commons/Files.java Outdated Show resolved Hide resolved

scireum-mbo added 3 commits December 10, 2024 15:59

Changes parameter name and comparison logic

e93e144

Fixes: SIRI-1028

Formats file accordingly

34b3f95

Fixes: SIRI-1028

Removes some testcases for isConsideredMetadata test

b44bcab

Fixes: SIRI-1028

sabieber approved these changes Dec 10, 2024

View reviewed changes

idlira approved these changes Dec 10, 2024

View reviewed changes

scireum-mbo merged commit 1cb8647 into develop Dec 11, 2024
3 checks passed

scireum-mbo deleted the feature/mbo/SIRI-1028 branch December 11, 2024 08:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Files: Implements methods isHidden and isMetadata to check if a path is either hidden or a type of metadata file #544

Files: Implements methods isHidden and isMetadata to check if a path is either hidden or a type of metadata file #544

scireum-mbo commented Dec 10, 2024

idlira left a comment

Files: Implements methods isHidden and isMetadata to check if a path is either hidden or a type of metadata file #544

Files: Implements methods isHidden and isMetadata to check if a path is either hidden or a type of metadata file #544

Conversation

scireum-mbo commented Dec 10, 2024

Additional Notes

Checklist

idlira left a comment

Choose a reason for hiding this comment