Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING: Improve the token-autocomplete clear button alignment #1451

Merged
merged 3 commits into from
Aug 23, 2024
Merged

BREAKING: Improve the token-autocomplete clear button alignment #1451

merged 3 commits into from
Aug 23, 2024

Conversation

jmuscireum
Copy link
Contributor

@jmuscireum jmuscireum commented Aug 23, 2024 •
edited
Loading

Description

Applies adjustments for the latest token-autocomplete and fixes a styling bug.

t:singleSelect looks good:

Bildschirmfoto 2024-08-23 um 14 06 34

w:lookupTable looks good:

Bildschirmfoto 2024-08-23 um 12 14 51

Tokens in t:multiSelect have the same height over multiple lines:

Bildschirmfoto 2024-08-23 um 11 30 25

Breaking

CSS rules or other uses of the CSS classes might have to be adjusted.

Additional Notes

Checklist

  • Code change has been tested and works locally
  • Code was formatted via IntelliJ and follows SonarLint & best practices
  • Patch Tasks: Is local execution of Patch Tasks necessary? If so, please also mark the PR with the tag.

@jmuscireum
Apply adjustments for the latest token-autocomplete
8988e84 
Fixes: SIRI-984
@jmuscireum
Ensure the correct height of tokens
40f1f96 
If the input wraps into the second line, the tokens on the first were not high enough.

Fixes: SIRI-984
@jmuscireum jmuscireum added 🧬 Enhancement Contains new features 💣 BREAKING CHANGE Contains non-backwards compatible changes to public methods or changes the behavior of existing code labels Aug 23, 2024
@jmuscireum jmuscireum mentioned this pull request Aug 23, 2024
Merged
2 tasks
@jmuscireum jmuscireum added the 🖐 Keep open Should not be merged label Aug 23, 2024
@jmuscireum jmuscireum removed the 🖐 Keep open Should not be merged label Aug 23, 2024
@jmuscireum jmuscireum merged commit 7089b3f into develop Aug 23, 2024
4 checks passed
@jmuscireum jmuscireum deleted the feature/jmu/SIRI-984-autocomplete-clear-button-alignment branch August 23, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymo-sci ymo-sci ymo-sci approved these changes

@idlira idlira idlira approved these changes

@fhaScireum fhaScireum fhaScireum approved these changes

@jakobvogel jakobvogel jakobvogel approved these changes

@sabieber sabieber sabieber approved these changes

Assignees
No one assigned
Labels
💣 BREAKING CHANGE Contains non-backwards compatible changes to public methods or changes the behavior of existing code 🧬 Enhancement Contains new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jmuscireum @sabieber @jakobvogel @fhaScireum @idlira @ymo-sci