Filter out hidden elements in sirius.addElementVisibleListener #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hidden elements have a bounding client rect at the top of the viewport and thus the listener is triggered immediately after the page is loaded. This adds a simple check for visibility by checking the width and height of the bounding client rect. Fixes: SE-13968
jmuscireum
added
🐛 Bugfix
fhaScireum
approved these changes
Sep 5, 2024
mkeckmkeck
approved these changes
Sep 5, 2024
sabieber
approved these changes
Sep 5, 2024
jakobvogel
approved these changes
Sep 5, 2024
The observed performance impact (as checked by the Chrome profiler) was minimal. Fixes: SE-13968
mkeckmkeck
approved these changes
Sep 6, 2024
scireum-mbo
approved these changes
Sep 9, 2024
ymo-sci
approved these changes
Sep 9, 2024
mko-sci
approved these changes
Sep 11, 2024
ymo-sci
deleted the
feature/jmu/SE-13968-hidden-elements-are-not-visible
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hidden elements have a bounding client rect at the top of the viewport and thus the listener is triggered immediately after the page is loaded.
This adds a simple check for visibility by checking the width and height of the bounding client rect.
Additional Notes
Checklist