CSS Design System - Reorder design system rules to enable more flexible overwriting #1458
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CSS rules of the same specificity (most of our helpers only use a single class, so have the specificity 0,1,0) are applied in the order they are loaded/defined. This means that we should place more specific helpers below more board components to increase the flexibility. Doing so reduces the need for !important markings on rules, which can get quite out of hand.
Examples of what the proposed changes allow to do:
sci-button-primary sci-p-1
- allows to reduce the default padding of our button classsci-d-flex sci-d-none
- Allows to hide an element and show it as soon as thesci-d-none
is removed (the JS code does not need to know what proper display class has to be added)Concrete example:
sci-d-none
is removedSource:
https://developer.mozilla.org/en-US/docs/Web/CSS/Specificity
Additional Notes
Checklist