SASS Fixes #1459
Merged
SASS Fixes #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by using proper variable names (rather than single letters and such) and removing unnecessary fully qualified type names. The code has been reformatted afterwards. No other (intended) changes in this commit. OX-10783
OX-10783
The generator was missing assets in the /default directory under certain circumstances. It generally seems safer to resolve resources via our framework anyway. OX-10783
mkeckmkeck
approved these changes
Sep 6, 2024
sabieber
approved these changes
Sep 6, 2024
…as extending the path with a leading slash is already done in the `Resources` class. OX-10783 Co-authored-by: Sascha Bieberstein <sbi@scireum.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Primarily fixes the way the SASS parser handles the import of other stylesheets. This is now done via a Sirius helper class,
Resources, in order to also cover files in the/default/directory. Along with that, the code of the SASS implementation is generally revised.Additional Notes
Checklist