Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes config keys for smtps protocol #1465

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

bkositza
Copy link
Contributor

@bkositza bkositza commented Oct 8, 2024

Description

Note that if you're using the "smtps" protocol to access SMTP over SSL, all the properties would be named "mail.smtps.*".

Additional Notes

  • This PR fixes or works on following ticket(s): SIRI-1023

Checklist

  • Code change has been tested and works locally
  • Code was formatted via IntelliJ and follows SonarLint & best practices
  • Patch Tasks: Is local execution of Patch Tasks necessary? If so, please also mark the PR with the tag.

@bkositza bkositza added the 🐛 Bugfix Contains only a small fix for an existing bug label Oct 8, 2024
@jakobvogel
Copy link
Member

  1. This seems to be breaking, as at least configurations need to be adapted? Am I right?
  2. If so, is it necessary? I.e. is this really a "bug" or just a "convention" that we are no longer happy with and want to change?

@bkositza
Copy link
Contributor Author

bkositza commented Oct 8, 2024

  1. This seems to be breaking, as at least configurations need to be adapted? Am I right?
  2. If so, is it necessary? I.e. is this really a "bug" or just a "convention" that we are no longer happy with and want to change?

Only the keys of the system properties are adjusted here, as these are read out accordingly by SMTP protocol provider, as can be read here (link below). Therefore it is a real bug.
https://eclipse-ee4j.github.io/angus-mail/docs/api/org.eclipse.angus.mail/org/eclipse/angus/mail/smtp/package-summary.html

"Note that if you're using the "smtps" protocol to access SMTP over SSL, all the properties would be named "mail.smtps.*"."

@bkositza bkositza merged commit 05abd73 into develop Oct 9, 2024
4 checks passed
@bkositza bkositza deleted the bugfix/bko/support-smtps-protocol-props branch October 9, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bugfix Contains only a small fix for an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants