Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade library versions #1486

Merged
merged 6 commits into from
Dec 4, 2024
Merged

Upgrade library versions #1486

merged 6 commits into from
Dec 4, 2024

Conversation

mkeckmkeck
Copy link
Contributor

@mkeckmkeck mkeckmkeck commented Dec 4, 2024 •
edited
Loading

Description

Fixes: SIRI-1036
Wait for scireum/sirius-parent#45 and scireum/sirius-kernel#542

BREAKING CHANGES:

  • org.xhtmlrenderer.extend.FSImage#scale now operates immutable. Means you need to use the returned value.

Additional Notes

  • This PR fixes or works on following ticket(s): SIRI-1036
  • This PR is related to PR:

Checklist

  • Code change has been tested and works locally
  • Code was formatted via IntelliJ and follows SonarLint & best practices
  • Patch Tasks: Is local execution of Patch Tasks necessary? If so, please also mark the PR with the tag.

@mkeckmkeck mkeckmkeck added 🖐 Keep open Should not be merged ⬆️ Dependencies Pull requests that update a dependency file labels Dec 4, 2024
sabieber
sabieber approved these changes Dec 4, 2024
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
src/main/java/sirius/web/data/ExcelExport.java Outdated Show resolved Hide resolved
sabieber and others added 3 commits December 4, 2024 08:36
@mkeckmkeck mkeckmkeck removed the 🖐 Keep open Should not be merged label Dec 4, 2024
@mkeckmkeck
Fixes all api breakages of org.xhtmlrenderer.extend.FSImage#scale
01063b9 
- not only those covered by tests

Fixes: SIRI-1036
@mkeckmkeck mkeckmkeck added the 💣 BREAKING CHANGE Contains non-backwards compatible changes to public methods or changes the behavior of existing code label Dec 4, 2024
@sabieber sabieber merged commit a82379e into develop Dec 4, 2024
4 checks passed
@sabieber sabieber deleted the mke/SE-1036_lib_upgrades branch December 4, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scireum-mbo scireum-mbo scireum-mbo approved these changes

@mko-sci mko-sci mko-sci approved these changes

@jakobvogel jakobvogel jakobvogel approved these changes

@sabieber sabieber sabieber approved these changes

Assignees
No one assigned
Labels
💣 BREAKING CHANGE Contains non-backwards compatible changes to public methods or changes the behavior of existing code ⬆️ Dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mkeckmkeck @sabieber @jakobvogel @mko-sci @scireum-mbo