Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable Centos Stream versions #158

Merged
merged 1 commit into from
Aug 10, 2022
Merged

disable Centos Stream versions #158

merged 1 commit into from
Aug 10, 2022

Conversation

pkubatrh
Copy link
Member

both rhel8 and rhel9 images are available in UBI

@pkubatrh
disable Centos Stream versions
c160154 
both rhel8 and rhel9 images are available in UBI
@pkubatrh pkubatrh requested review from phracek and zmiklank August 10, 2022 08:13
zmiklank
zmiklank reviewed Aug 10, 2022
View reviewed changes
Copy link
Contributor

@zmiklank zmiklank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The c9s and c8s is also mentioned in run_default_page_test and run_as_root_test functions that are part of 2.4/test/run.

Do we want to address also that?

Else LGTM.

@pkubatrh
Copy link
Member Author

Thanks for the review!

The c9s and c8s is also mentioned in run_default_page_test and run_as_root_test functions that are part of 2.4/test/run.

I kept those in for the future case where we introduce a new version of httpd that we want to ship in either Stream.

Merging without tests as the changes will only take effect after the PR is merged (and I will be running tests as part of #138 anyway)

@pkubatrh pkubatrh merged commit 16a426c into sclorg:master Aug 10, 2022
@pkubatrh pkubatrh deleted the disable_stream branch August 10, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmiklank zmiklank zmiklank left review comments

@phracek phracek Awaiting requested review from phracek

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkubatrh @zmiklank