fix testsuite return value reporting #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the tests use ct_cleanup which exits on its own with "$TESTSUITE_RESULT" as the return value of the whole script. The tests are however using "$overall". This commit renames "overall" to "TESTSUITE_RESULT" to propagate the value correctly.
|
[test-all] |
phracek
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
LGTM. Based on the calling ct_cleanup https://github.com/sclorg/container-common-scripts/blob/master/test-lib.sh#L59
Let's wait for the tests.
|
Tests are green. I have manually checked the logs to make sure everything is actually passing. We can test the CI failures in #138, so lets merge and rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the tests use ct_cleanup which exits on its own with "$TESTSUITE_RESULT"
as the return value of the whole script. The tests are however using "$overall".
This commit renames "overall" to "TESTSUITE_RESULT" to propagate the value correctly.