Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-init scripts functionality #28

Merged
merged 1 commit into from
Oct 2, 2017
Merged

Add pre-init scripts functionality #28

merged 1 commit into from
Oct 2, 2017

Conversation

kosciCZ
Copy link
Contributor

@kosciCZ kosciCZ commented Sep 25, 2017

This PR adds ability to have pre-init scripts in the httpd s2i image, in the same way as in sclorg/mongodb-container. It also comes with a test that validates this functionality.

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

1 similar comment
@rhscl-bot
Copy link

Can one of the admins verify this patch?

@omron93
Copy link

omron93 commented Sep 25, 2017

[test]

@kosciCZ
Copy link
Contributor Author

kosciCZ commented Sep 27, 2017

@omron93 The build in ci.centos.org isn't starting, nor is in the queue. Perhaps because this project[1] is disabled? Can this please be looked into?

[1] https://ci.centos.org/job/SCLo-container-httpd-rh/

@omron93
Copy link

omron93 commented Sep 27, 2017

@kosciCZ Thanks for pointing this out. We are working on solving CentOS CI problems.

@kosciCZ
Copy link
Contributor Author

kosciCZ commented Oct 2, 2017

@omron93 Could you please trigger the tests again? It seems this project is enabled again on ci.centos.org. Thank you

@pkubatrh
Copy link
Member

pkubatrh commented Oct 2, 2017

[test]

@omron93
Copy link

omron93 commented Oct 2, 2017

Everything looks good to me. And tests are passing so +1 for merging.

@pkubatrh or @hhorak If you are OK with this please merge...

@pkubatrh
Copy link
Member

pkubatrh commented Oct 2, 2017

lgtm as well, thanks! Merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants